Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IMAP search keyword parsing #485

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

apinske
Copy link
Contributor

@apinske apinske commented Sep 30, 2022

not the best fix. the spec says flag is an atom. but the same code path is used to parse e.g. UID 1:*. so we would maybe need to provide a way for search keys to specify the type of arguments.

e.g. in
	NOT (KEYWORD ABC)
the flag was parsed as ABC) instead of just ABC
@apinske apinske changed the base branch from master to releases/1.6.x September 30, 2022 22:21
@marcelmay marcelmay self-assigned this Oct 2, 2022
@marcelmay marcelmay added bug backport_1_6_x Backport to old bugfixing branch 1.6.x labels Oct 2, 2022
@marcelmay marcelmay added this to the 2.0.0-alpha-3 milestone Oct 2, 2022
@marcelmay
Copy link
Member

@apinske , thx alot! Yes, making search keys aware of atom/word/.. for args would be the pretty solution.

@marcelmay marcelmay merged commit 9c2d87a into releases/1.6.x Oct 2, 2022
@marcelmay marcelmay removed the backport_1_6_x Backport to old bugfixing branch 1.6.x label Oct 2, 2022
@marcelmay marcelmay modified the milestones: 2.0.0-alpha-3, 1.6.11 Oct 2, 2022
marcelmay pushed a commit that referenced this pull request Oct 2, 2022
The flag was parsed as ABC) instead of just ABC

Forward port of #485
@apinske apinske deleted the bugfix/imap-search-parse-keyword-paren branch October 4, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants