Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vlan counters #22

Merged
merged 1 commit into from
Sep 8, 2022
Merged

add vlan counters #22

merged 1 commit into from
Sep 8, 2022

Conversation

sherrieshen
Copy link
Contributor

@sherrieshen sherrieshen commented Aug 8, 2022 •
edited
Loading

  • Add support for CLI "show vlan counters"
  • Add testing for vlan counters
  • Updated markdown file

@sherrieshen sherrieshen force-pushed the vlan-counters branch 4 times, most recently from 9c2161e to f2d2dfc Compare August 15, 2022 21:35
@leslie-qiwa
Copy link
Contributor

leslie-qiwa commented Sep 8, 2022 •
edited
Loading

@greenpau can you provide any comments on this PR? I do need this feature to monitor vlan statistics

@greenpau
Copy link
Owner

greenpau commented Sep 8, 2022

@leslie-qiwa , it is all good. Need to find the time to merge and release

@leslie-qiwa
Copy link
Contributor

Thanks for prompt reply! Maybe you can just merge, and we'll use master directly. I also found one potential bug, and may supply a patch shortly.

@greenpau
Copy link
Owner

greenpau commented Sep 8, 2022

I also found one potential bug, and may supply a patch shortly.

@leslie-qiwa , please send it. This way I will release.

@greenpau greenpau merged commit 110fa41 into greenpau:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherrieshen @leslie-qiwa @greenpau