Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hmis::File duplicate versions regression #4872

Closed
wants to merge 1 commit into from

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Oct 29, 2024

Merging this PR

  • use the squash-merge strategy

Description

Fix bug introduced to release-139 by https://github.com/greenriver/hmis-warehouse/pull/4857/files#r1819961086 whereby duplicate PaperTrail versions were created for Hmis::Files, because has_paper_trail was defined on the parent class too. This is currently causing test failures on CI.

See linked comment for full context

Type of change

Bug fix

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

@eanders
Copy link
Contributor

eanders commented Oct 29, 2024

@gigxz I think this is less intrusive, and actually what we wanted.
#4874
The base File class gets inherited from for a bunch of report files and others that really don't need to have paper trail.

@gigxz
Copy link
Contributor Author

gigxz commented Oct 29, 2024

great @eanders thanks

@gigxz gigxz closed this Oct 29, 2024
@gigxz gigxz deleted the gig/fix-duplicate-file-versions-pt branch October 29, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants