APR Q4a residential affiliation mapping

[dtgreiner]

Merging this PR

• use the squash-merge strategy for PRs targeting a release-X branch
• use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Update APR Q4a to pull affiliated residential projects using residential_projects instead of residential_affiliations. residential_projects appears to be bringing back the residential projects that are affiliated with said project as opposed to residential_affiliations which appears to be looking for projects that a residential project is affiliated with.

Type of change

Bug fix

Checklist before requesting review

• I have performed a self-review of my code
• I have run the code that is being changed under ideal conditions, and it doesn't fail
• If adding a new endpoint / exposing data in a new way, I have:
  • ensured the API can't leak data from other data sources
  • ensured this does not introduce N+1s
  • ensured permissions and visibility checks are performed in the right places
• I have updated the documentation (or not applicable)
• I have added spec tests (or not applicable)
• I have provided testing instructions in this PR or the related issue (or not applicable)

//: # NOTE: system tests may fail if there is no branch on the hmis-frontend that matches the Source or Target branch of this PR. This is expected

[eanders]

Thanks @dtgreiner !