Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit_assignment form #5023

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Dec 29, 2024

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Remove this form, which we plan to manage in the form builder instead of version control. This will allow us to set editor_user_ids on the form.

Issue: https://github.com/open-path/Green-River/issues/7093

When deployed, we'll need to:

Type of change

config

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

//: # NOTE: system tests may fail if there is no branch on the hmis-frontend that matches the Source or Target branch of this PR. This is expected

@gigxz gigxz marked this pull request as ready for review December 30, 2024 15:28
@gigxz gigxz requested a review from ttoomey December 30, 2024 15:29
@gigxz gigxz merged commit 30b3a97 into release-146 Dec 31, 2024
54 checks passed
@gigxz gigxz deleted the gig/7093-remove-unit_assignment branch December 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants