Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 2023 SPM into new 2024 version #5043

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Copy 2023 SPM into new 2024 version #5043

merged 2 commits into from
Jan 9, 2025

Conversation

dtgreiner
Copy link
Contributor

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Create a 2024 version of the SPM as a copy of the 2023 version. The new 2023 version is set as inactive for new runs but will still allow viewing historical reports. The tests in the 2023 version were also copied to a new 2024 version.

Type of change

New Feature

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

//: # NOTE: system tests may fail if there is no branch on the hmis-frontend that matches the Source or Target branch of this PR. This is expected

@dtgreiner dtgreiner requested a review from eanders January 9, 2025 14:38
@dtgreiner dtgreiner mentioned this pull request Jan 9, 2025
9 tasks
Copy link
Contributor

@eanders eanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @dtgreiner !

@eanders eanders merged commit aab1129 into release-147 Jan 9, 2025
54 checks passed
@eanders eanders deleted the dg/spm_2024-7076 branch January 9, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants