Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build image failure #5055

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Fix build image failure #5055

merged 7 commits into from
Jan 14, 2025

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Jan 14, 2025 •
edited
Loading

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Fix build image failure https://github.com/greenriver/hmis-warehouse/actions/runs/12769568906/job/35594525191
I'm not sure why this fixes it, was a suggestion from @yakloinsteak

Type of change

add dependency

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

//: # NOTE: system tests may fail if there is no branch on the hmis-frontend that matches the Source or Target branch of this PR. This is expected

gigxz
gigxz commented Jan 14, 2025
View reviewed changes
docker/app/Dockerfile
@@ -69,6 +69,7 @@ RUN apk update \
tzdata \
git \
bash \
linux-headers \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes ffi installation error on build

gigxz
gigxz commented Jan 14, 2025
View reviewed changes
.github/dependencies.txt
@@ -48,4 +48,5 @@ ttf-droid
ttf-freefont
ttf-liberation
tzdata
yarn
yaml-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes psych installation on container setup

@gigxz gigxz requested review from eanders and yakloinsteak January 14, 2025 17:53
@gigxz gigxz marked this pull request as ready for review January 14, 2025 17:53
eanders
eanders approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@eanders eanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gigxz !

@eanders eanders mentioned this pull request Jan 14, 2025
Merged
5 tasks
@gigxz gigxz merged commit 680bd21 into release-147 Jan 14, 2025
54 checks passed
@gigxz gigxz deleted the gig/try-fix-build branch January 14, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eanders eanders eanders approved these changes

@yakloinsteak yakloinsteak yakloinsteak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gigxz @yakloinsteak @eanders