Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an equals implementation for Properties object. Ran into an issue which raised the following exception.
It was caused by evaluating the equality of two property objects using == instead of .equals(), within WhereCollector.java.
I managed to track the origin of the issue to a poorly written unit test within my own codebase which I believe was mocking an object using powermock, in such a scenario == wasn't sufficient. I corrected the unit test, so its no longer a blocker to myself, however providing an equals implementation seems like a good thing to do anyway.
You may wish to remove the WhereCollector unit test as its somewhat redundant. Also whats the deal with the encryption branch. I assume pull requests are being made against master and master will then be merged into encryption before a release.
Ive also sent the contributor agreement.
Thanks,
Emmet
Original issue: #216