Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip_sidebar! visible #1454

Merged
merged 2 commits into from
Jul 6, 2012
Merged

Make skip_sidebar! visible #1454

merged 2 commits into from
Jul 6, 2012

Conversation

jpmckinney
Copy link
Contributor

See recent comments in #257. The code posted by @gregbell in the issue (#257 (comment)) doesn't work. This commit makes it work.

@travisbot
Copy link

This pull request passes (merged 875494d into 65c1e4e).

@pcreux
Copy link
Contributor

pcreux commented Jul 4, 2012

Could you add a spec / scenario to test this behavior?

@jpmckinney
Copy link
Contributor Author

Spec added. Remove include Sidebars from ResourceController to see the test fail.

@travisbot
Copy link

This pull request passes (merged a4235d5 into 65c1e4e).

pcreux added a commit that referenced this pull request Jul 6, 2012
@pcreux pcreux merged commit 5a4c121 into activeadmin:master Jul 6, 2012
profmaad pushed a commit to profmaad/activeadmin-mongoid that referenced this pull request Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants