Multiple React applications on same page support #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregberge
force-pushed
the
multiple-app-support
branch
from
a49e333
to
d352f43
Compare
gregberge
force-pushed
the
multiple-app-support
branch
from
d352f43
to
a15f3ec
Compare
gregberge
pushed a commit
that referenced
this pull request
Apr 23, 2019
|
Thanks for your work! |
9 tasks
fivethreeo
pushed a commit
to fivethreeo/loadable-components
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311
Summary
Loadable components currently doesn't support having multiple react apps on the same page. This is because it uses the hardcoded id of
__LOADABLE_REQUIRED_CHUNKS__in a script tag to check if a chunk has loaded. This PR aims to add the feature to add a namespace to each app to make this possible.Test plan
Added test cases on the server side to make sure that the namespace was being added to the
scriptid.On the client side, verified manually if loading 2 different react apps triggers 2 different
loadableevents