Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Promise.resolve in the events no queries are found #6

Merged
merged 1 commit into from
Jul 16, 2017

Conversation

nylin93
Copy link
Contributor

@nylin93 nylin93 commented Jul 15, 2017

When on the server doing:

getLoadableState(app).then(loadableState => { ... })
if no queries are found, throws an error because DeferredState is returned, not a Promise.

@codecov
Copy link

codecov bot commented Jul 15, 2017

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          12       12           
  Lines         109      109           
  Branches       27       27           
=======================================
  Hits          101      101           
  Misses          7        7           
  Partials        1        1
Impacted Files Coverage Δ
src/server/index.js 87.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b777fc...1361ff7. Read the comment docs.

@gregberge gregberge merged commit 2d24d3c into gregberge:master Jul 16, 2017
@gregberge
Copy link
Owner

gregberge commented Jul 16, 2017

Thanks, I added the test e67b5b2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants