Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #592 #607

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix: #592 #607

merged 2 commits into from
Sep 2, 2020

Conversation

markwoodward23
Copy link
Contributor

Summary

Fixes #592

Test plan

Unit tests all pass + local linking.

@markwoodward23 markwoodward23 mentioned this pull request Aug 4, 2020
Closed
@markwoodward23
Copy link
Contributor Author

markwoodward23 commented Sep 2, 2020 •
edited
Loading

How do we get this released @gregberge / @theKashey ?

@theKashey theKashey merged commit a586997 into gregberge:master Sep 2, 2020
@theKashey
Copy link
Collaborator

🤜 starting preparing the new release

@theKashey theKashey mentioned this pull request Sep 5, 2020
Merged
@theKashey theKashey mentioned this pull request Sep 15, 2020
Closed
@markwoodward23 markwoodward23 deleted the fix-get-script-elements branch October 9, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theKashey theKashey theKashey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chunkExtractor.getScriptElements returns nested array in 5.13.1
3 participants
@markwoodward23 @theKashey @willdurand