fix: do not derive cache key if component is static

[theKashey]

Summary

For components, which are static, there is no reason to derive cache key from props.

👉 Do not derive cache key if component is static, fixes #629

[diffidentDude]

Nice, this looks like it would fix the issue we were having, is there an alpha to test with?

[theKashey]

@diffidentDude - any change that you can replace null -> "static" directly in your node_modules to double check that it works fine for you?

[diffidentDude]

@diffidentDude - any change that you can replace null -> "static" directly in your node_modules to double check that it works fine for you?

Sure, can do.

[caizx666]

TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Object'
| property 'backendConnector' -> object with constructor 't'
| property 'backend' -> object with constructor 'e'
--- property 'services' closes the circle
at JSON.stringify ()
at o.a.getCacheKey (loadable.esm.js:227)
at o.a.getCache (loadable.esm.js:235)
at o.a.componentDidMount (loadable.esm.js:192)
at Sr (react-dom.production.min.js:212)
at oi (react-dom.production.min.js:255)
at t.unstable_runWithPriority (scheduler.production.min.js:19)
at Ut (react-dom.production.min.js:122)
at ii (react-dom.production.min.js:248)
at Ur (react-dom.production.min.js:239)

[theKashey]

@caizx666 - you mean #629, this is the fix for your problem.

[caizx666]

Yes

[kuoruan]

Any update for this commit?

[theKashey]

oof, a week already passed. If someone can confirm (@diffidentDude 😉) that is solving the problem, and not creating a new one - I can release the update immediately.

I just not quite trust build in unit tests and had no free time to test stuff manually.

[bevacqua]

This was merged a week ago but it hasn't been published as a new npm package version yet. Can we get 5.13.3? 🙇

[theKashey]

Just double checking webpack5 before the new release...