-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not derive cache key if component is static #630
Conversation
Nice, this looks like it would fix the issue we were having, is there an alpha to test with? |
@diffidentDude - any change that you can replace |
Sure, can do. |
TypeError: Converting circular structure to JSON |
Yes |
Any update for this commit? |
oof, a week already passed. If someone can confirm (@diffidentDude 😉) that is solving the problem, and not creating a new one - I can release the update immediately. I just not quite trust build in unit tests and had no free time to test stuff manually. |
This was merged a week ago but it hasn't been published as a new npm package version yet. Can we get |
Just double checking webpack5 before the new release... |
Summary
For components, which are static, there is no reason to derive cache key from props.
👉 Do not derive cache key if component is static, fixes #629