Cache promise on load/preload

[macko911]

Summary

I guess the cache in preload and load methods is not used on purpose but I was curious whether you'd be interested in this change, maybe under an option or a different static method cache.

The use case for me is that I did try to prefetch pages on link hover, but after transiting to the prefetched page I saw a blink of white page in between the route transitions, even though I was blocking the transition until the module was fetched.

This only happened on the first transition, subsequent transitions to the cached pages didn't have the blink anymore, which lead me to this change.

[cecchi]

Hey @theKashey -- is this ready to go? Not sure I understood the review comment, but happy to help with implementation if I can. We're running into this issue as well.

Edit: looking again, is the suggestion to reuse the cached promise if one exists? In other words, only assign to cache[getCacheKey()] if the cache is not already populated?

[theKashey]

Everything is fine, I am just have developed a habit to always seek for perfection as mentoring our devs is a big part of my job.
And that is not the best habit.

gonna merge this PR and apply changes I would like to see by myself, that’s just a few lines change.

[theKashey]

Everything is fine, I am just have developed a habit to always seek for perfection as mentoring our devs is a big part of my job.
And that is not the best habit.

gonna merge this PR and apply changes I would like to see by myself, that’s just a few lines change.

[macko911]

Thanks @theKashey, I'd do the change myself but unfortunately don't really know what you meant by your original comment. Probably better to just do it yourself like you said 👍 . Would be really glad to stop using my fork of the repo. Cheers!