Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onLoad in options #847

Closed
wants to merge 3 commits into from
Closed

Conversation

jinasonlin
Copy link
Contributor

Summary

Add onLoad in options. When async component load finish, onLoad will be trigger.

Test plan

Previous comments #839

@theKashey theKashey self-requested a review December 12, 2021 01:13
@theKashey
Copy link
Collaborator

There is a little question to answer - when to call onLoad - on the first load, or on the every "load"(even if it did not happen)

@theKashey theKashey self-assigned this Dec 12, 2021
@jinasonlin
Copy link
Contributor Author

I expect that is on the first load, like the library's onload.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@stale stale bot closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants