-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-native --icon should be 24 not 1em #571
Comments
Hey @FDiskas 👋, |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
👯♂️ |
@FDiskas why the choice of 24? 1em = 16px by default in browser. |
Yes you are right. Why px? It's more universal unit. This module is used not only on web. 1em does nothing in native mobile apps |
@FDiskas no I mean why choosing 24 instead of 16? |
Good question, don't know. Just numbers :) |
@FDiskas OK we need to make it configurable then. There is no way to specify something that can be decided later by user or implied by font size like em? |
I was thinking 🤔 if there is option "native" so that could mean that em is not valid any more in the output and would be replaced to simple integers if it has --icon pram. But to configure the output size would be nice addition. Like: |
BREAKING CHANGE: using --icon as latest arg now requires "--" Fix #571
🐛 Bug Report
In react native 1em width does nothing - suppose to be rem?
To Reproduce
Go to playground https://react-svgr.com/playground/?icon=true&native=true&typescript=true
Expected behavior
I would like to get results with width and height as 24
Workaround in
.svgrrc.js
The text was updated successfully, but these errors were encountered: