Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed thread-segregation from Variable and let. #118

Merged

Conversation

ashleyfrieze
Copy link
Contributor

Fixes #115 and supersedes #117. This removes (for now) the artificial thread-separate introduced with the Variable class and let hook added in release 1.1.0.

I will work out how to make parallel execution thread safe in its own PR.

@codecov
Copy link

codecov bot commented Aug 24, 2017

Codecov Report

Merging #118 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #118      +/-   ##
===========================================
- Coverage      99.3%   99.3%   -0.01%     
- Complexity      332     333       +1     
===========================================
  Files            40      40              
  Lines           717     716       -1     
  Branches         22      22              
===========================================
- Hits            712     711       -1     
  Partials          5       5
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/greghaskins/spectrum/Variable.java 100% <100%> (ø) 4 <2> (+1) ⬆️

@greghaskins
Copy link
Owner

@ashleyfrieze looks great. +1 for the tests too. I'll merge and push a new version by tomorrow.

@ashleyfrieze
Copy link
Contributor Author

I think you know me well enough to know I'm a test first guy :)

What kind of test framework would not have tests for discovered bugs in boundary conditions!!!?

This is going to make parallel tests much harder to implement.

@ashleyfrieze
Copy link
Contributor Author

By the way, coverage is down because there is less code rather than less coverage.

@greghaskins greghaskins merged commit b7b920a into greghaskins:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants