feat(): add TikTok mentions and hashtags #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - Looking forward to this feature :) |
|
Awesome. Can we get this merged! |
|
@gregjacobs Could you please take a look? |
|
@olafleur Could you please take a look / review? |
|
Hey guys, so sorry for the delay on this. Great job adding this, and appreciate the contribution! |
|
Oof, can't release this change just yet. Had a bunch of failing tests, and seems Autolinker's CI integration shut down so we didn't see it on this PR. Fixing now |
|
Just realizing too: did you forget to push some files? For instance, I don't see any changes to mention-matcher.ts for a TikTok regexp |
|
Ok I fixed things up and released as v3.15.0 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TikTok has also fixed url for:
https://www.tiktok.com/tag/+ hashtaghttps://www.tiktok.com/@+ mentionSo we could add this functionality to support this network too.