Don't check no-effect warning since doc is not a valid attribute for …

…repository_rule

Tracked in bazelbuild/buildtools#471

internal/npm_install/npm_install.bzl

@@ -214,9 +214,6 @@ cd "{root}" && "{npm}" {npm_args}
 
 npm_install = repository_rule(
     implementation = _npm_install_impl,
-    doc = """
-Runs npm install during workspace setup.
-""",
     attrs = dict(COMMON_ATTRIBUTES, **{
         "timeout": attr.int(
             default = 3600,
@@ -228,6 +225,9 @@ Runs npm install during workspace setup.
         ),
     }),
 )
+"""
+Runs npm install during workspace setup.
+"""
 
 def _yarn_install_impl(repository_ctx):
     """Core implementation of yarn_install."""
@@ -296,9 +296,6 @@ def _yarn_install_impl(repository_ctx):
 
 yarn_install = repository_rule(
     implementation = _yarn_install_impl,
-    doc = """
-Runs yarn install during workspace setup.
-""",
     attrs = dict(COMMON_ATTRIBUTES, **{
         "timeout": attr.int(
             default = 3600,
@@ -325,3 +322,6 @@ Runs yarn install during workspace setup.
         ),
     }),
 )
+"""
+Runs yarn install during workspace setup.
+"""

package.json

@@ -55,7 +55,9 @@
         "//   uninitialized": "./internal/node/node.bzl:95: uninitialized: Variable 'd' may not have been initialized. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#uninitialized)",
         "//   uninitialized(2)": "./internal/node/node.bzl:95: uninitialized: Variable 'd' may not have been initialized. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#uninitialized)",
         "//   uninitialized(3)": "./packages/typescript/internal/build_defs.bzl:95: uninitialized: Variable 'output' may not have been initialized. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#uninitialized)",
-        "bazel:format": "find . -type f \\( -name \"*.bzl\" -or -name WORKSPACE -or -name BUILD -or -name BUILD.bazel \\) ! -path \"*/node_modules/*\" ! -path \"./dist/*\" ! -path \"./third_party/*\" | xargs buildifier -v --warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,confusing-name,constant-glob,ctx-actions,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,function-docstring,git-repository,http-archive,integer-division,load,load-on-top,module-docstring,name-conventions,native-build,native-package,no-effect,out-of-order-load,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,return-value,same-origin-load,string-iteration,unreachable,unsorted-dict-items,unused-variable",
+        "//   no-effect": "./internal/npm_install/npm_install.bzl:228: no-effect: Expression result is not used. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#no-effect)",
+        "//   no-effect(2)": "./internal/npm_install/npm_install.bzl:325: no-effect: Expression result is not used. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#no-effect)",
+        "bazel:format": "find . -type f \\( -name \"*.bzl\" -or -name WORKSPACE -or -name BUILD -or -name BUILD.bazel \\) ! -path \"*/node_modules/*\" ! -path \"./dist/*\" ! -path \"./third_party/*\" | xargs buildifier -v --warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,confusing-name,constant-glob,ctx-actions,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,function-docstring,git-repository,http-archive,integer-division,load,load-on-top,module-docstring,name-conventions,native-build,native-package,out-of-order-load,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,return-value,same-origin-load,string-iteration,unreachable,unsorted-dict-items,unused-variable",
         "bazel:lint": "yarn bazel:format --lint=warn",
         "bazel:lint-fix": "yarn bazel:format --lint=fix",
         "format": "git-clang-format",