Replace gridList to grid #1565
Merged
Replace gridList to grid #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wdh2100 whats your email or npm user? so i can add you for contributors |
|
@gregnb |
|
@wdh2100 are you up for doing the next release? |
|
Not yet... |
|
@wdh2100 dohwoo is not valid username on npm |
|
hmm... Could you do it again with this? |
|
@wdh2100 has to be a username |
|
Isn't this your username? |
|
oh sorry Add my github account
|
|
@wdh2100 all set |
I would just include your 3 PRs and update the package version to 3.7.0. |
|
Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1559
The usability is the same.
However, there may be some differences.
It looks like the use of abnormal components(
GridList), so I fixed it.And there are also component changes in v5.
GridList => ImageList
These changes seem to clarify the purpose.
https://material-ui.com/components/grid/
https://material-ui.com/components/grid-list/