Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from PR feedback #6

Conversation

peternied
Copy link

Description

Updates from PR feedback - gets the upstream PR unblocked.

Signed-off-by: Peter Nied <peternied@hotmail.com>
…tionResource

Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
@peternied
Copy link
Author

Well after merging from main this is much harder to inspect :/ Actual interesting commits:
a152666
2a26039
2159a2a

@peternied
Copy link
Author

@gregschohn Thanks for making these changes manually - nothing was needed from this PR.

@peternied peternied closed this Sep 10, 2024
@peternied peternied deleted the NodeIdAsAnInstrumentationResource branch September 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant