Optionally bracket all library with namespace #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESP8266 (and probably others) have conflicting class naes for "File"
and a few other names defined in SdFat.
To guard against this, when the symbol "SDFAT_NAMESPACE" is defined at
compile-time, bracket all objects, globals, constants, etc. in a
"namespace sdfat { ... };" block.
All examples updated to add "using namespace sdfat;" when required,
meaning that they compile and run whether or not the define is set.
No changes to existing apps are needed.
|
@greiman, this and PR #120 are related to my efforts to help replace the ancient Arduino "SD" lib with an ESP8266 Arduino code filesystem based on your latest and greatest library (esp8266/Arduino#5525). Thanks for your continued work on this library! |
|
SdFat source will soon be totally replaced by a new version that supports exFAT. The new version is derived from the SdFs code. |
|
Thanks for the fast feedback on this. I'll simply maintain a fork for now and am looking forward to the exFAT update! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESP8266 (and probably others) have conflicting class names for "File"
and a few other names defined in SdFat.
To guard against this, when the symbol "SDFAT_NAMESPACE" is defined at
compile-time, bracket all objects, globals, constants, etc. in a
"namespace sdfat { ... };" block.
All examples updated to add "using namespace sdfat;" when required,
meaning that they compile and run whether or not the define is set.
No changes to existing apps are needed.