Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: rename format_mem and format_swap to fromat and format_alt #1644

Merged
merged 8 commits into from
Oct 17, 2022

Conversation

madhur
Copy link
Contributor

@madhur madhur commented Oct 16, 2022

Fixes issue #1642

src/blocks/memory.rs Outdated Show resolved Hide resolved
src/blocks/memory.rs Outdated Show resolved Hide resolved
@MaxVerevkin
Copy link
Collaborator

Memtype type can be removed.

@MaxVerevkin
Copy link
Collaborator

Please run rustfmt --edition 2021 src/blocks/memory.rs. Apparently cargo fmt (and cargo fmt --check) doesn't work on blocks' files because their mod <module> is defined inside of a macro. This is a known limitation of cargo fmt: rust-lang/rustfmt#4078

@ammgws I guess the CI should run something like rustfmt --check --edition 2021 $(fd -e rs) instead of cargo fmt --check?

@madhur madhur requested a review from MaxVerevkin October 17, 2022 06:34
@MaxVerevkin
Copy link
Collaborator

Please update the docs on lines 9-10

src/blocks/memory.rs Outdated Show resolved Hide resolved
src/blocks/memory.rs Outdated Show resolved Hide resolved
madhur and others added 2 commits October 17, 2022 13:22
Co-authored-by: Max Verevkin <34583604+MaxVerevkin@users.noreply.github.com>
NEWS.md Outdated Show resolved Hide resolved
src/blocks/memory.rs Outdated Show resolved Hide resolved
@MaxVerevkin
Copy link
Collaborator

Thanks!

@MaxVerevkin MaxVerevkin merged commit 919b2d6 into greshake:master Oct 17, 2022
This was referenced Oct 17, 2022
@MaxVerevkin MaxVerevkin added enhancement breaking Breaking changes labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants