-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nameserver information to network block #2058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Should I squash the commits into a single one or it is fine the way it is? |
I usually do "squash and merge", so no need to do it manually. |
Looks like this breaks the [[block]]
block = "net"
device = "wlp3s0"
format = "$icon $signal_strength $speed_down $graph_down $speed_up $graph_up $frequency"
missing_format = "no net"
[[block]]
block = "net"
device = "enp2s0f0"
format = " $speed_down $graph_down $speed_up $graph_up" I only get "Failed to read nameservers" twice with this. |
@matthiaskrgr can you share the output of |
|
Hmm, we currently don't handle the |
I mean in the context of resolv.conf. Is it that this nameserver is interface-specific? |
Now tracked in #2080 |
This PR is the first implementation to add more information to the network block.
The previous discussion was held in the following issue #2053. Specifically the first step of reading the
nameservers
saved inetc/resolv.conf
.It files that are modified are
netlinks.rs
andnet.rs
. With the former being the one that changes the most by creating a function to read the file, modify the Device struct and the last file by updating the documentation and adding the information to be displayed.