block[weather]: Remove redundant code #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxVerevkin
reviewed
Jul 11, 2024
bim9262
force-pushed
the
clear_weather
branch
2 times, most recently
from
c612e16
to
495c239
Compare
|
Replaced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
combine_forecaststhat @Cognoscan just added from nws to be used by all of the backends (nowForecast::new).Added
ForecastAggregateSegmentwhich has the same members asForecastAggregate, but makes all of the fields Optional since met.no does not promise that they're included in the response.