block[disk_iostats]: new block #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
disk-stats
branch
2 times, most recently
from
20cd87c to
1dd6b38
Compare
|
Does any of the maintainers have an opinion on this PR? Is the idea good? Is the name fine? Is the approach taken good enough? |
|
Looks good! Didn't have enough time to explicitly write this sooner, waiting for the docs :) |
emersion
force-pushed
the
disk-stats
branch
2 times, most recently
from
64786e8 to
8df0fac
Compare
|
Added docs! |
MaxVerevkin
reviewed
Jan 19, 2025
|
Naming nit - perhaps |
|
Sure, renamed |
ammgws
approved these changes
Feb 9, 2025
MaxVerevkin
reviewed
Feb 9, 2025
Reads disk I/O stats from sysfs. See: https://docs.kernel.org/admin-guide/iostats.html
thewalkingforest
pushed a commit
to thewalkingforest/i3status-rust
that referenced
this pull request
Feb 10, 2025
Reads disk I/O stats from sysfs. See: https://docs.kernel.org/admin-guide/iostats.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads disk stats from sysfs.
TODO:
io_statswould be a better name? Orblock_device_stats? Not sure.See: https://docs.kernel.org/admin-guide/iostats.html