Simplify volume_muted icons #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if there's anything I can do to help move this along |
ammgws
reviewed
Mar 22, 2020
|
@carloabelli This is what I get: Using
|
|
Ah I see now that Font Awesome 4 is still being used (per #130). Though it does appear that the underlying pango issue causing many of the hex box problems has been fixed here. Perhaps it would be worth considering an update to the Font Awesome 5 at this point? I can either wait on this commit until a decision is made there, or I can revert it to the old glyph. I am using
|
This was referenced Apr 21, 2020
|
Changes now included in #619. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing something, but font awesome includes a volume mute icon so we should just use that instead of attempting to build it out of multiple icons. It is also possible to simplify the code around creating custom mute icons. Not sure if there is a default volume mute icon for material icons, but would be happy to amend.