-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate Classpaths of CLI Runner and Servlet Container #280
Conversation
Concept taken from: https://github.com/gretty-gradle-plugin/gretty/blob/beff12a24d0da6f80441d03835f4f97733643987/libs/gretty-runner-jetty94/src/main/java/org/akhikhl/gretty/FilteringClassLoader.java#L89-L118 This will stop the leakage of runner implementation details like Logback and Commons-CI into the classpath of the servlet container.
- Gretty should be open to more than one logging framework. Webapps must not have more than one logging framework on their classpath. - Because servlet containers have different versions requirements on slf4j, and, by extension, Logback, maintaining Logback support in Gretty is not feasible.
I think it's correct as-is, and if we added the commit, the built was bound to fail. You did good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much Boris for your herculean effort! 💪
One day, we'll port the build logic to cleanly split build and test environments from 3.x, too, but that is topic for another day 😄
The herculean effort was yours in the beginning, it was much easier now to just take the commits and just resolve the conflicts. :) I believe the only issue was with Logback - I had to update the version to 1.4.x for the build to pass. Anyway, thanks, merging! :) |
Port of #270 to
master
.cc @f4lco