Isolate Classpaths of CLI Runner and Servlet Container #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concept taken from: https://github.com/gretty-gradle-plugin/gretty/blob/beff12a24d0da6f80441d03835f4f97733643987/libs/gretty-runner-jetty94/src/main/java/org/akhikhl/gretty/FilteringClassLoader.java#L89-L118 This will stop the leakage of runner implementation details like Logback and Commons-CI into the classpath of the servlet container.
- Gretty should be open to more than one logging framework. Webapps must not have more than one logging framework on their classpath. - Because servlet containers have different versions requirements on slf4j, and, by extension, Logback, maintaining Logback support in Gretty is not feasible.
I think it's correct as-is, and if we added the commit, the built was bound to fail. You did good 👍 |
f4lco
approved these changes
Dec 19, 2022
|
The herculean effort was yours in the beginning, it was much easier now to just take the commits and just resolve the conflicts. :) I believe the only issue was with Logback - I had to update the version to 1.4.x for the build to pass. Anyway, thanks, merging! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #270 to
master.cc @f4lco