Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gretty 3.x forwardports #283

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Gretty 3.x forwardports #283

merged 2 commits into from
Jan 16, 2023

Conversation

boris-petrov
Copy link
Member

Port a couple of commits from gretty-3.x to master.

ArLau and others added 2 commits January 6, 2023 17:39
@ArLau @boris-petrov
Remove check for missing slf4j provider
785c414 
Fixes #275

Slf4j issues a warning in case the provider is missing. Furthermore, the checked provider list might not be complete and is currently outdated resulting in false-positives.
@boris-petrov
Remove usage of Spring Boot's LiveReloadServer
df23cf7 
As that causes conflicts in user projects:
#277
f4lco
f4lco approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@f4lco f4lco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you so much 💯

@boris-petrov boris-petrov merged commit aae36a7 into master Jan 16, 2023
@boris-petrov boris-petrov deleted the gretty-3.x-forwardports branch January 16, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f4lco f4lco f4lco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boris-petrov @f4lco @ArLau