Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger presence detection #20

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Debugger presence detection #20

merged 2 commits into from
Dec 9, 2024

Conversation

BrainBacon
Copy link
Contributor

@BrainBacon BrainBacon commented Nov 29, 2024

This adds the ability to check for debuggers using the functionality from the dbg_breakpoint crate.

That crate doesn't have any ecosystem usage currently, but it comes from a PR that was merged into Rust and then reverted later.

I've audited the crate source and pinned the 0.1.1 version to avoid any possible supply-chain attacks since the crate is so small and new.

Additionally I added a cache for the debugger presence result and added a feature no_cache_debugger to skip the cache.

@BrainBacon BrainBacon added the enhancement New feature or request label Nov 29, 2024
@BrainBacon BrainBacon requested a review from girtonman November 29, 2024 19:20
@BrainBacon BrainBacon self-assigned this Nov 29, 2024
@BrainBacon BrainBacon marked this pull request as ready for review December 9, 2024 10:09
Copy link
Contributor

@girtonman girtonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

One small thing to address before merge: In cargo.toml, dbg_breakpoint is pinned to 0.1.1 instead of 0.1.0. Either the PR description or the code needs updating.

@girtonman girtonman merged commit a351fa1 into main Dec 9, 2024
@girtonman girtonman deleted the fix/debugger branch December 9, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants