GM-117868: Adds parse transform for Level/3 function to pass submeta as map #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarBitMan
commented
Aug 16, 2023
| {Meta, SubMeta, Message, Arguments}; | ||
| break_args(DefaultAttrs, Line, Args) -> | ||
| {Meta, Message, Arguments} = handle_args(DefaultAttrs, Line, Args), | ||
| {Meta, {map, Line, []}, Message, Arguments}. |
There was a problem hiding this comment.
Default SubMeta = #{}.
AST for #{} -> {map, Line, []}
| @@ -96,7 +96,7 @@ output(sev,Msg) -> | |||
| output(metadata, Msg) -> | |||
| output({metadata, "=", " "}, Msg); | |||
| output({metadata, IntSep, FieldSep}, Msg) -> | |||
| MD = lists:keysort(1, lager_msg:metadata(Msg)), | |||
| MD = lists:usort(lager_msg:metadata(Msg)), | |||
There was a problem hiding this comment.
remove duplicates, case where submeta and meta both have the same KVs.
| @@ -149,8 +152,10 @@ do_log_impl(Severity, Metadata, Format, Args, SeverityAsInt, LevelThreshold, Tra | |||
| _ -> | |||
| Format | |||
| end, | |||
| io:format("Metadata = ~p, SubMeta = ~p", [Metadata, SubMeta]), | |||
amarBitMan
changed the title
amarBitMan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can use
Sink:Level/4function.Where the first arg of this function will be a map of all key-value pairs to be prepended to Msg String.