Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to what we discussed. @amartinhuertas @fverdugo
A little context:
The current implementation of the sparse matrix assembly is (loosely) done as follows:
InserterCSC
object, with a similar layout toSparseMatrixCSC
.Both of these have the advantage of saving memory, but at the cost of doing sparse row/col index searches every time we assemble an entry.
We would like to investigate the option of working with COO-type structures. These are more expensive memory-wise, but can save quite a lot of time when re-assembling the matrix.
I've added a MWE on a possible implementation of the latter. Also, here are some results from the benchmarks at the end: