Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General polytope implementation #1006

Merged
merged 6 commits into from
May 15, 2024
Merged

General polytope implementation #1006

merged 6 commits into from
May 15, 2024

Conversation

pmartorell
Copy link
Collaborator

@pmartorell pmartorell commented May 15, 2024

@santiagobadia

This PR includes the implementation of general polytopes in Gridap.

These polytopes are named GeneralPolytope<:Polyhedron. Here, Polygon and Polyhedron are aliases of GeneralPolytope in 2 and 3 dimensions, respectively.

We note, that this implementation has been migrated from STLCutters.jl, see also gridap/STLCutters.jl#33

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 93.24324% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 88.26%. Comparing base (34faf27) to head (8b70346).

Files Patch % Lines
src/ReferenceFEs/GeneralPolytopes.jl 93.24% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
+ Coverage   88.18%   88.26%   +0.08%     
==========================================
  Files         176      177       +1     
  Lines       22055    22425     +370     
==========================================
+ Hits        19449    19794     +345     
- Misses       2606     2631      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santiagobadia
Copy link
Member

@pmartorell can you replace GraphPolytope by GeneralPolytope?

@pmartorell
Copy link
Collaborator Author

@santiagobadia I have changed the name

@santiagobadia santiagobadia merged commit 9079dd1 into master May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants