Skip to content

Commit

Permalink
Merge pull request #33 from gridap/polytope
Browse files Browse the repository at this point in the history
Define `Polyhedron` as `GeneralPolytope<:Gridap.Polytope`
  • Loading branch information
pmartorell authored Jul 29, 2024
2 parents f362f07 + b572bd1 commit 06ab663
Show file tree
Hide file tree
Showing 10 changed files with 206 additions and 303 deletions.
9 changes: 9 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed

- `Polyhedron` is now defined in `Gridap` as `GeneralPolytope{3}<Polytope{3}`. Its internal `data` is renamed to `metadata`.
- `get_data(::Polyhedron)` is renamed to `get_metadata(::Polyhedron)`.
- `simplexify(::Polyhedron)` now returns the same data structure as `simplexify(::Polytope)`. The previous implementation is renamed to `simplexify_interior`.
- `check_graph` is renamed to `check_polytope_graph`.

## [0.2.1] - 2024-07-11

### Added
Expand Down
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "STLCutters"
uuid = "284f087d-c8bb-44c4-af3c-39d0e1f330a5"
authors = ["Pere Antoni Martorell", "Large Scale Scientific Computing"]
version = "0.2.1"
version = "0.3.0"

[deps]
AlgebraicMultigrid = "2169fc97-5a83-5252-b627-83903c6c433c"
Expand All @@ -24,7 +24,7 @@ AlgebraicMultigrid = "0.5, 0.6"
Downloads = "1.4"
FileIO = "1.6"
FillArrays = "0.11, 0.13, 1"
Gridap = "0.18"
Gridap = "0.18.3"
GridapDistributed = "0.4"
GridapEmbedded = "0.9.4"
IterativeSolvers = "0.9"
Expand Down
2 changes: 1 addition & 1 deletion src/Distributed.jl
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ end

# PR @ GridapDistributed.jl

function Gridap.ReferenceFEs.simplexify(model::DistributedDiscreteModel{D};kwargs...) where D
function _simplexify(model::DistributedDiscreteModel{D};kwargs...) where D
models = map(local_views(model)) do m
Gridap.ReferenceFEs.simplexify(m;kwargs...)
end
Expand Down
Loading

0 comments on commit 06ab663

Please sign in to comment.