Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PROTOCOL_ERROR #199

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fix PROTOCOL_ERROR #199

merged 2 commits into from
Apr 20, 2021

Conversation

nvthongswansea
Copy link
Contributor

There is a bug in go which caused the body of a HTTP2 upgraded request disappears during retry. The issue occasionally happens when concurrency is used. To solve this issue, I force the http client to use HTTP 1.1 explicitly (no HTTP2 upgrade). Furthermore, update golang to v1.16 in go.mod file.

Copy link
Contributor

@bkircher bkircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bkircher bkircher merged commit cf9f35b into master Apr 20, 2021
@bkircher bkircher deleted the fixProtocErr branch April 20, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants