-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pip and pip-tools from requirements #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 46.52% 46.52%
=======================================
Files 49 49
Lines 2730 2730
Branches 551 551
=======================================
Hits 1270 1270
Misses 1405 1405
Partials 55 55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
appdirs==1.4.4 | ||
# via virtualenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these rendered like this? I recall that this is not the first time, do you have any clue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New pip-tools version AFAIK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hassan754 @spyrostz exactly: jazzband/pip-tools#1237. This is done to avoid git conflicts.
Adding these two packages to the requirements is considered to be unsafe, and it's also generating errors/warnings because of incompatibilities with some of our dependencies. Updating
pip
andpip-tools
should be manually done by the dev.pip
andpip-tools
from explicit requirementspip-compile
frompip-tools
)