Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations for import and export used by gridstudy and gridexplore #628

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

basseche
Copy link
Contributor

@basseche basseche commented Oct 25, 2024

Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact same translation sometimes exist in the import file and is missing in the export file, and sometimes the reverse :

Are in the export localizations but not the import :

  • generatorFortescue
  • lineFortescue
  • threeWindingsTransformerFortescue
  • twoWindingsTransformerFortescue

Are in the import localizations but not the export :

  • voltageRegulation

src/translations/fr/exportParamsFr.ts Outdated Show resolved Hide resolved
src/translations/fr/importParamsFr.ts Outdated Show resolved Hide resolved
@basseche
Copy link
Contributor Author

The exact same translation sometimes exist in the import file and is missing in the export file, and sometimes the reverse :

Are in the export localizations but not the import :

* generatorFortescue

* lineFortescue

* threeWindingsTransformerFortescue

* twoWindingsTransformerFortescue

Are in the import localizations but not the export :

* voltageRegulation

it is ok Import and export doesn't have to be the same.
some labels were removed (TODO)

@basseche basseche closed this Oct 29, 2024
@basseche basseche reopened this Oct 29, 2024
@Mathieu-Deharbe
Copy link
Contributor

Mathieu-Deharbe commented Oct 29, 2024

The exact same translation sometimes exist in the import file and is missing in the export file, and sometimes the reverse :
Are in the export localizations but not the import :

* generatorFortescue

* lineFortescue

* threeWindingsTransformerFortescue

* twoWindingsTransformerFortescue

Are in the import localizations but not the export :

* voltageRegulation

it is ok Import and export doesn't have to be the same. some labels were removed (TODO)

It looks like they are still used in the study creation :

création de situ

Copy link
Contributor

@thangqp thangqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, should place into a directory translations/external/en et fr because these translation keys are not hardcoded in TS files but retrieved from other systems

In similarity, for keys which are composed dynamically in the code TS, we should place into a dynamic directory as in study-app

These conventions were proposed by Charly from a long time.. so you can ask @EstherDarkish

@basseche basseche force-pushed the unify-translations-gridExplore-gridStudy branch 2 times, most recently from 5670c91 to 647fde5 Compare October 31, 2024 10:05
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
@basseche basseche force-pushed the unify-translations-gridExplore-gridStudy branch from 647fde5 to f6e056f Compare October 31, 2024 10:30
Copy link

sonarcloud bot commented Oct 31, 2024

@thangqp thangqp self-requested a review October 31, 2024 10:37
@basseche basseche merged commit c2a7e0c into main Oct 31, 2024
4 checks passed
@basseche basseche deleted the unify-translations-gridExplore-gridStudy branch October 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants