-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translations for import and export used by gridstudy and gridexplore #628
Conversation
apps unified in commons-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exact same translation sometimes exist in the import file and is missing in the export file, and sometimes the reverse :
Are in the export localizations but not the import :
- generatorFortescue
- lineFortescue
- threeWindingsTransformerFortescue
- twoWindingsTransformerFortescue
Are in the import localizations but not the export :
- voltageRegulation
it is ok Import and export doesn't have to be the same. |
It looks like they are still used in the study creation : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, should place into a directory translations/external/en et fr because these translation keys are not hardcoded in TS files but retrieved from other systems
In similarity, for keys which are composed dynamically in the code TS, we should place into a dynamic directory as in study-app
These conventions were proposed by Charly from a long time.. so you can ask @EstherDarkish
5670c91
to
647fde5
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
647fde5
to
f6e056f
Compare
Quality Gate passedIssues Measures |
related to :
gridsuite/gridstudy-app#2352
gridsuite/gridexplore-app#554