Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextField adornments warnings #637

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix TextField adornments warnings #637

merged 2 commits into from
Nov 20, 2024

Conversation

Meklo
Copy link
Contributor

@Meklo Meklo commented Nov 14, 2024 •
edited
Loading

Prevents the following warnings :

Warning: React does not recognize the `adornmentText` prop on a DOM element.
Warning: React does not recognize the `adornmentPosition` prop on a DOM element.

By not passing those props only when Field is a TextField instead of a TextFieldWithAdornment

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dbraquart dbraquart self-requested a review November 20, 2024 17:50
dbraquart
dbraquart approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok "adornment" warnings are gone

@dbraquart dbraquart merged commit eb2ad28 into main Nov 20, 2024
4 checks passed
@dbraquart dbraquart deleted the fix/adornment_warnings branch November 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbraquart dbraquart dbraquart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meklo @dbraquart