migrate aggrid into v33 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
This was referenced Jan 14, 2025
AbdelHedhili
approved these changes
Jan 15, 2025
Tristan-WorkGH
approved these changes
Jan 22, 2025
| @@ -66,7 +66,6 @@ export const CustomAGGrid = React.forwardRef<AgGridReact, CustomAGGridProps>((pr | |||
| <AgGridReact | |||
| ref={ref} | |||
| getLocaleText={getLocaleText} | |||
| suppressPropertyNamesCheck | |||
| onColumnResized={onColumnResized} | |||
| enableCellTextSelection | |||
| {...agGridReactProps} | |||
There was a problem hiding this comment.
We still use the old styling system.
Suggested change
| {...agGridReactProps} | |
| theme="legacy" | |
| {...agGridReactProps} |
| @@ -92,7 +83,7 @@ export interface CustomAgGridTableProps { | |||
| defaultColDef: unknown; | |||
| pagination: boolean; | |||
| paginationPageSize: number; | |||
| suppressRowClickSelection: boolean; | |||
| rowSelection?: RowSelectionOptions | 'single' | 'multiple'; | |||
There was a problem hiding this comment.
would prefer
Suggested change
| rowSelection?: RowSelectionOptions | 'single' | 'multiple'; | |
| rowSelection?: AgGridReactProps['rowSelection']; |
There was a problem hiding this comment.
dunno if the provideGlobalGridOptions({ theme: 'legacy' }); in fronts also affect the ones in this library 🤔
| @@ -243,11 +234,10 @@ export function CustomAgGridTable({ | |||
| onGridReady={onGridReady} | |||
| getLocaleText={getLocaleText} | |||
| cacheOverflowSize={10} | |||
| rowSelection="multiple" | |||
| rowSelection={rowSelection || 'multiple'} | |||
There was a problem hiding this comment.
Suggested change
| rowSelection={rowSelection || 'multiple'} | |
| rowSelection={rowSelection ?? 'multiple'} |
| @@ -259,7 +249,6 @@ export function CustomAgGridTable({ | |||
| getRowId={(row) => row.data[FieldConstants.AG_GRID_ROW_UUID]} | |||
| pagination={pagination} | |||
| paginationPageSize={paginationPageSize} | |||
| suppressRowClickSelection={suppressRowClickSelection} | |||
| alwaysShowVerticalScroll={alwaysShowVerticalScroll} | |||
| stopEditingWhenCellsLoseFocus={stopEditingWhenCellsLoseFocus} | |||
| {...props} | |||
There was a problem hiding this comment.
We still use the old styling system.
Suggested change
| {...props} | |
| theme="legacy" | |
| {...props} |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.