Auto-Increment and Error Messaging for Duplicate Contingency List Names in Script #277
Conversation
…ters contingency list Name when Copied to Script Signed-off-by: achour94 <berrahmaachour@gmail.com>
…ters contingency list Name when Copied to Script Signed-off-by: achour94 <berrahmaachour@gmail.com>
…increment_alias_copy_name
| if (initialValue !== '') { | ||
| updateFormState(initialValue); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
forbidden in our code base :)
…increment_alias_copy_name
…increment_alias_copy_name
Signed-off-by: achour94 <berrahmaachour@gmail.com>
| useEffect(() => { | ||
| if (initialValue !== '') { | ||
| updateFormState(initialValue); | ||
| setValue(initialValue); |
There was a problem hiding this comment.
Does this effect run multiple times ? If not, there's not need for setValue as initialValue is passed to the useState() ?
There was a problem hiding this comment.
It's a bad name "initialValue" if it triggers additional behaviors when it changes. In react the convention is to only use the value for the first render
There was a problem hiding this comment.
yes, it willl trigger the useeffect twice in the case we will get the name from the backend
| <CircularProgress /> | ||
| ) : ( | ||
| <NameWrapper | ||
| initialValue={generatedName} |
There was a problem hiding this comment.
I would fix the initialValue behavior and restore the value={...} and onChange{...} prop
| open, | ||
| onClose, | ||
| onClick, | ||
| currentName, | ||
| title, | ||
| }) => { | ||
| const [newNameValue, setNewNameValue] = React.useState(currentName); | ||
| const [generatedName, setGeneratedName] = useState(''); | ||
| const [newNameValue, setNewNameValue] = useState(currentName); |
There was a problem hiding this comment.
Why we do use generatedName and newNameValue
Maybe one is enough
There was a problem hiding this comment.
because in that case (initialValue={newNameValue}) the useEffect with initialValue as a dependency will be triggered each time newNameValue is changed
|
replaced with #285 |
Implement Automatic Incrementation and Error Message for existing filters contingency list Name when Copied to Script