-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/clear on close type #540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: capyq <quentin.capy@rte-france.com>
Signed-off-by: capyq <quentin.capy@rte-france.com>
capyq
force-pushed
the
fix/clearOnCloseType
branch
from
October 17, 2024 12:51
f9a87b3
to
e6e7fea
Compare
Quality Gate passedIssues Measures |
Confict to manage with Mathieu |
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
thangqp
added a commit
to gridsuite/commons-ui
that referenced
this pull request
Nov 19, 2024
Related PR: gridsuite/gridexplore-app#540 Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
TheMaskedTurtle
approved these changes
Nov 21, 2024
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in onClose prop coming from common-ui.
Related PR (blocking): gridsuite/commons-ui#641