Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clear on close type #540

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Fix/clear on close type #540

merged 7 commits into from
Nov 21, 2024

Conversation

capyq
Copy link
Contributor

@capyq capyq commented Oct 10, 2024

Fix typo in onClose prop coming from common-ui.

Related PR (blocking): gridsuite/commons-ui#641

capyq added 2 commits October 10, 2024 11:47
Signed-off-by: capyq <quentin.capy@rte-france.com>
Signed-off-by: capyq <quentin.capy@rte-france.com>
@capyq capyq force-pushed the fix/clearOnCloseType branch from f9a87b3 to e6e7fea Compare October 17, 2024 12:51
Copy link

sonarcloud bot commented Oct 17, 2024

@TheMaskedTurtle
Copy link
Contributor

Confict to manage with Mathieu

Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
thangqp added a commit to gridsuite/commons-ui that referenced this pull request Nov 19, 2024
Related PR: gridsuite/gridexplore-app#540

Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Copy link

sonarcloud bot commented Nov 21, 2024

@thangqp thangqp merged commit d8b1c91 into main Nov 21, 2024
4 checks passed
@thangqp thangqp deleted the fix/clearOnCloseType branch November 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants