change the way we get case base name #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ghazwarhili
reviewed
Dec 18, 2024
| @@ -788,3 +788,11 @@ export function searchElementsInfos(searchTerm: string, currentDirectoryUuid: UU | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| export const getBaseName = (caseName: string) => { | |||
| const caseNameUrl = `${PREFIX_CASE_QUERIES}/v1/cases/caseBaseName?caseName=${caseName}`; | |||
There was a problem hiding this comment.
encodeURIComponent(caseName)
| @@ -788,3 +788,11 @@ export function searchElementsInfos(searchTerm: string, currentDirectoryUuid: UU | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| export const getBaseName = (caseName: string) => { | |||
There was a problem hiding this comment.
add console.info('Get base name for case', caseName);
or something else
| setValue(name, caseName?.substring(0, caseName.indexOf('.')), { | ||
| shouldDirty: true, | ||
| }); | ||
| if (caseName.length > 0) { |
There was a problem hiding this comment.
you have to check the caseName trimming maybe
if (caseName.trim().length > 0) {
| setValue(name, response, { | ||
| shouldDirty: true, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Add error handling
.catch((error) => { console.error('Error fetching base name:', error); });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to work this evolution must take use powsybl-case-server version : //TODO put version