Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ReadMe.MD #48

Closed
jonathan-schoeps opened this issue Sep 25, 2024 · 2 comments · Fixed by #58
Closed

Update the ReadMe.MD #48

jonathan-schoeps opened this issue Sep 25, 2024 · 2 comments · Fixed by #58
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jonathan-schoeps
Copy link
Contributor

jonathan-schoeps commented Sep 25, 2024

Update

There is insufficient documentation on how to use the "fixed element composition".

@marcelmbn
Copy link
Member

marcelmbn commented Oct 2, 2024

This is probably also relevant for the ternary oxides, so it might make sense that you enhance the README.md for this (currently not well documented) case, @jonathan-schoeps.

To-Do's:

How shall the user know how constitutional isomers are set up?

  • Can also be realized by an improved mindlessgen.toml

@marcelmbn marcelmbn added the documentation Improvements or additions to documentation label Oct 2, 2024
@marcelmbn
Copy link
Member

marcelmbn commented Oct 2, 2024

In addition to this, the following part of mindlessgen.toml is a bit inconsistent (just noticed after merging #51).

# > Scaling factor for the employed van der Waals radii. Options: <float>
scale_vdw_radii = 1.2
# > Scaling factor for the minimal bondlength based on the sum of the van der Waals radii. Options: <float>
scale_minimal_bondlength = 0.75

Which radii (for which purpose) are scaled in the end? This should be more clear and consistent, @jonathan-schoeps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants