Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce more general fragmentation test #34

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

marcelmbn
Copy link
Member

  • existing iterative_optimization test contained an ill-defined molecule
  • let's now take a well-defined benzene dimer
  • absolute instead of relative distance thresholds for the optimization check

Signed-off-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Signed-off-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
@marcelmbn marcelmbn self-assigned this Sep 14, 2024
@marcelmbn marcelmbn added bug Something isn't working invalid This doesn't seem right labels Sep 14, 2024
@marcelmbn marcelmbn merged commit fe436f9 into grimme-lab:main Sep 16, 2024
10 checks passed
@marcelmbn marcelmbn deleted the fix/arbitrary_optimization_tests branch September 16, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants