Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release.yml more consistent #39

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:
concurrency:
group: ${{ github.event_name }}_${{ github.ref_name }}
permissions:
contents: write # IMPORTANT: mandatory for making GitHub Releases
id-token: write
contents: write # IMPORTANT: mandatory for making GitHub Releases
id-token: write # IMPORTANT: mandatory for OICD token
jobs:
# Build and verify wheels
build:
Expand Down Expand Up @@ -46,8 +46,9 @@ jobs:
# Upload to Test PyPI on every tag
release-test-pypi:
needs: build
name: Publish PyPI TEST
name: Publish to test.pypi.org
environment: release
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
runs-on: ubuntu-latest
steps:
- name: Download packages built
Expand All @@ -63,7 +64,7 @@ jobs:
# Upload to real PyPI on GitHub Releases.
release-pypi:
needs: build
name: Publish PyPI PROD
name: Publish to pypi.org
environment: release
if: github.event.action == 'published'
runs-on: ubuntu-latest
Expand All @@ -82,3 +83,5 @@ jobs:
path: dist
- name: Upload package to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
verbose: true