Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require element symbols to match symbol_length #22

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Nov 30, 2021

Constructor could fail due to symbol_length usage in the sorting step.

@awvwgk awvwgk added the bug Something isn't working label Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #22 (37c90f9) into main (e9b9348) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   64.50%   64.52%   +0.02%     
==========================================
  Files          49       49              
  Lines        4175     4175              
  Branches     1357     1357              
==========================================
+ Hits         2693     2694       +1     
  Misses        553      553              
+ Partials      929      928       -1     
Impacted Files Coverage Δ
test/testsuite_structure.f90 34.92% <ø> (ø)
src/mctc/io/symbols.f90 71.42% <100.00%> (ø)
src/mctc/io/structure.f90 53.44% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b9348...37c90f9. Read the comment docs.

@awvwgk awvwgk merged commit 4702007 into grimme-lab:main Nov 30, 2021
@awvwgk awvwgk deleted the symbol-length branch November 30, 2021 21:36
@awvwgk awvwgk mentioned this pull request Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant