Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated make_directory with file(MAKE_DIRECTORY) #45

Merged
merged 1 commit into from
May 23, 2022
Merged

replace deprecated make_directory with file(MAKE_DIRECTORY) #45

merged 1 commit into from
May 23, 2022

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented May 23, 2022

awvwgk
awvwgk approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing.

@codecov
Copy link

codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #45 (a387554) into main (874680b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   69.80%   69.80%           
=======================================
  Files          60       60           
  Lines        7616     7616           
  Branches     2232     2232           
=======================================
  Hits         5316     5316           
  Misses        739      739           
  Partials     1561     1561

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874680b...a387554. Read the comment docs.

@awvwgk awvwgk merged commit 8def2c5 into grimme-lab:main May 23, 2022
@e-kwsm e-kwsm deleted the make_directory branch May 23, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-kwsm @awvwgk