-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added actinide parameters. #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing. Looks good to me.
Could we maybe have a test which covers the new elements? Also, looks like the CI needs some attention to run our build correctly again.
Fixed the build CI for ubuntu/macos, thanks to @Albkat! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=========================================
+ Coverage 0 47.52% +47.52%
=========================================
Files 0 18 +18
Lines 0 1553 +1553
Branches 0 708 +708
=========================================
+ Hits 0 738 +738
- Misses 0 462 +462
- Partials 0 353 +353 ☔ View full report in Codecov by Sentry. |
Added the following actinide parameters. The errors are given in e- for the used fit set.
Overall, we find a mean squared error of 0.019e- and a root mean squared error of 0.137e-.