Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "--tmcosmo" mode for writing .cosmo files with TM convention. #864

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Add "--tmcosmo" mode for writing .cosmo files with TM convention. #864

merged 6 commits into from
Sep 20, 2023

Conversation

MtoLStoN
Copy link
Member

@MtoLStoN MtoLStoN commented Sep 13, 2023 •
edited
Loading

Related to #863. Uses the TM convention for the writing of .cosmo files in xTB when the "--tmcosmo" keyword is used.

Edit: Given the scope of this PR, this will now completely close #863 if merged.

@MtoLStoN
Add "--tmcosmo" mode for writing .cosmo files with TM convention.
d5dd8b9 
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN MtoLStoN mentioned this pull request Sep 13, 2023
Closed
Albkat
Albkat reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@Albkat Albkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to pass the set%solvInput%tmcosmo value to writeCosmoFile routine. This way you can get rid of the optional attribute, as well as redundant tm variable.

@Albkat Albkat added the enhancement New feature or request label Sep 14, 2023
@MtoLStoN
Add ddvolume module for Volume output (and handling improvement)
9996906 
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN
Copy link
Member Author

I generally agree. However, I just realized, that the TCosmo type is already available in the routine and I can therefore omit the additional variable in the call completely. This is nice and I would prefer it that way. What do you think?

Additionally, I added a volume output via a custom ddvolume module. It adds a little bit of computational overhead (about 3% for Taxol, I think), so for the moment it's only activated if you are choosing to use the TM convention.

@MtoLStoN MtoLStoN requested a review from Albkat September 18, 2023 12:55
@MtoLStoN
Remove debugging code snippet.
63deaf2 
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN
Include parallelization into ddvolume.
44fc011 
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN MtoLStoN requested a review from awvwgk September 20, 2023 09:08
@MtoLStoN MtoLStoN added this to the v6.7.0 milestone Sep 20, 2023
Albkat
Albkat reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@Albkat Albkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!
It might be worthwhile to consider adding a regression test for this.

src/prog/main.F90 Outdated Show resolved Hide resolved
@MtoLStoN
Remove unneccesary flag.
1f7a6cb 
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN MtoLStoN merged commit 9e67d6e into grimme-lab:main Sep 20, 2023
11 checks passed
@MtoLStoN MtoLStoN deleted the tmcosmo branch September 20, 2023 16:17
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
@MtoLStoN @Albkat @gorges97
Add "--tmcosmo" mode for writing .cosmo files with TM convention. (gr…
da50d3f 
…imme-lab#864)

* Add "--tmcosmo" mode for writing .cosmo files with TM convention.
* Add ddvolume module for Volume output (and handling improvement)

---------

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Co-authored-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Albkat Albkat Albkat approved these changes

@awvwgk awvwgk Awaiting requested review from awvwgk

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v6.7.0
Development

Successfully merging this pull request may close these issues.

COSMO Screening Charge and Volume
2 participants
@MtoLStoN @Albkat