Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accuracy -> set%acc #866

Merged
merged 1 commit into from
Sep 17, 2023
Merged

accuracy -> set%acc #866

merged 1 commit into from
Sep 17, 2023

Conversation

Albkat
Copy link
Member

@Albkat Albkat commented Sep 13, 2023

get rid of global SCC accuracy parameter

@Albkat
accuracy->set%acc
ba44dad 
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
@Albkat Albkat requested review from MtoLStoN and awvwgk September 13, 2023 17:44
@Albkat Albkat added the refactor Enhancing and optimizing source code for improved readability, maintainability, and performance label Sep 14, 2023
awvwgk
awvwgk approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Albkat Albkat merged commit a52f3d3 into grimme-lab:main Sep 17, 2023
11 checks passed
@Albkat Albkat deleted the set_acc branch September 17, 2023 19:46
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
@Albkat @gorges97
accuracy->set%acc (grimme-lab#866)
51fe2be 
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@MtoLStoN MtoLStoN Awaiting requested review from MtoLStoN

Assignees
No one assigned
Labels
refactor Enhancing and optimizing source code for improved readability, maintainability, and performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Albkat @awvwgk